Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinorPlanetsExpansion: switch to github #10386

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Conversation

JonnyOThan
Copy link
Contributor

The author has been unable to update this mod on spacedock, and the current release has a gamebreaking bug when installed with parallax. The fix is available on github, so let's just make that the primary download.

A Word of Warning: SpaceDock/CKAN Still Carries the Initial 1.1.0 Build
DO NOT Use 1.1.0's Parallax Config - THEY ARE UNSTABLE

https://forum.kerbalspaceprogram.com/topic/192848-112x-planet-pack-minor-planets-expansion/

https://forum.kerbalspaceprogram.com/topic/192848-112x-planet-pack-minor-planets-expansion/?do=findComment&comment=4439323

The author has been unable to update this mod on spacedock, and the current release has a gamebreaking bug when installed with parallax.  The fix is available on github, so let's just make that the primary download.

> A Word of Warning: SpaceDock/CKAN Still Carries the Initial 1.1.0 Build
DO NOT Use 1.1.0's Parallax Config - THEY ARE UNSTABLE

https://forum.kerbalspaceprogram.com/topic/192848-112x-planet-pack-minor-planets-expansion/

https://forum.kerbalspaceprogram.com/topic/192848-112x-planet-pack-minor-planets-expansion/?do=findComment&comment=4439323
@HebaruSan
Copy link
Member

@JonnyOThan, multi-hosting is for the use case where the mod is up to date on both servers.
If SpaceDock isn't being updated, we'll need to remove that kref.

@JonnyOThan
Copy link
Contributor Author

JonnyOThan commented Jan 30, 2025

Ah I thought it would take the first entry if they didn't match. It just fails to inflate? Then I think the only question is whether we should wait for confirmation from @ExosLab before removing the spacedock ref.

@HebaruSan
Copy link
Member

Right, the point is to catch cases where the author uploads 1.0 to SpaceDock and uses something else like v1.0 on GitHub. We need to catch those and adjust the netkans as appropriate rather than indexing separate versions that are actually the same.

@JonnyOThan JonnyOThan changed the title MinorPlanetsExpansion: add dual host, make github primary MinorPlanetsExpansion: switch to github Jan 30, 2025
@JonnyOThan
Copy link
Contributor Author

I'm kinda leaning towards committing this, it's easily undone if they want.

Copy link
Member

@HebaruSan HebaruSan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. The author is advising people to use this specific download, and may not be aware that CKAN can also switch. This seems like all upside.

@JonnyOThan JonnyOThan merged commit 6b8c42a into master Jan 30, 2025
2 checks passed
@JonnyOThan JonnyOThan deleted the update/MinorPlanetsExpansion branch January 30, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants